Implement code and pre blocks support on iOS#306
Implement code and pre blocks support on iOS#306maksg wants to merge 2 commits intoExpensify:mainfrom
Conversation
|
Still discussing the expected behavior for codeblocks here |
|
It looks like 
It's okay for the initial implementation but ultimately we'd like I don't think it's possible to achieve padding for inline code on iOS (Slack for iOS also does not support it). However, I think it should be possible to implement padding for codeblocks. As for horizontal padding, I've copied this code from blockquotes and it seems to work: react-native-live-markdown/ios/RCTMarkdownUtils.mm Lines 119 to 122 in cd42c45 
As for vertical padding, ChatGPT says that the only option is to set We can implement that in a follow-up PR. |
|
There seems to be some problem with codeblocks containing only one character: Screen.Recording.2024-04-17.at.01.52.15.mov |
maksg
force-pushed
the
@maksg/code-and-pre-blocks
branch
from
09f4caf to
76bed9d
Compare
maksg
force-pushed
the
@maksg/code-and-pre-blocks
branch
from
76bed9d to
dfc3362
Compare
maksg
force-pushed
the
@maksg/code-and-pre-blocks
branch
from
dfc3362 to
a5d038c
Compare
maksg
force-pushed
the
@maksg/code-and-pre-blocks
branch
from
a5d038c to
589feb1
Compare
|
Closing in favor of #720. Thanks again for the hard work! |
2 participants
Details
Adds support for displaying and customising code and pre blocks on iOS.